Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource: azurerm_application_insights_workbook_template #17433

Merged
merged 8 commits into from
Jul 8, 2022
Merged

New Resource: azurerm_application_insights_workbook_template #17433

merged 8 commits into from
Jul 8, 2022
+1,589 −1

Conversation

ms-zhenhua
Copy link
Contributor

@ms-zhenhua ms-zhenhua commented Jun 29, 2022 •
edited
Loading

tombuildsstuff
tombuildsstuff suggested changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments but this otherwise LGTM 👍

internal/services/applicationinsights/validate/workbook_template_id.go Outdated Show resolved Hide resolved
internal/services/applicationinsights/application_insights_workbook_template_resource.go Outdated Show resolved Hide resolved
@ms-zhenhua
Copy link
Contributor Author

Hi @tombuildsstuff, thank you for reviewing my code. I have resolved the comments, kindly help review it again. Thanks.

katbyte
katbyte approved these changes Jul 8, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎩

@katbyte katbyte merged commit 15347cf into hashicorp:main Jul 8, 2022
katbyte added a commit that referenced this pull request Jul 8, 2022
@katbyte
CHANGELOG #17433
08cc9f0
@github-actions github-actions bot added this to the v3.14.0 milestone Jul 8, 2022
@github-actions
Copy link

This functionality has been released in v3.14.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@tombuildsstuff tombuildsstuff Awaiting requested review from tombuildsstuff

Assignees
No one assigned
Labels
dependencies documentation service/application-insights size/XL
Projects
None yet
Milestone
v3.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ms-zhenhua @tombuildsstuff @katbyte